-
Notifications
You must be signed in to change notification settings - Fork 916
Support writing encrypted Parquet files with plaintext footers #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rok
wants to merge
23
commits into
apache:main
Choose a base branch
from
rok:gh-7320-write-encrypted-with-plaintext-footer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support writing encrypted Parquet files with plaintext footers #7439
rok
wants to merge
23
commits into
apache:main
from
rok:gh-7320-write-encrypted-with-plaintext-footer
+213
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43b1242
to
8491010
Compare
adamreeve
reviewed
Apr 30, 2025
66fa295
to
6432214
Compare
3339491
to
0261b29
Compare
0261b29
to
77707b2
Compare
77707b2
to
631839c
Compare
adamreeve
reviewed
May 6, 2025
Co-authored-by: Adam Reeve <[email protected]>
631839c
to
8b1aace
Compare
45290c0
to
5a33909
Compare
5a33909
to
1ab252b
Compare
alamb
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rok and @adamreeve -- this also looks great to me
let column_2_key = "1234567890123451".as_bytes(); | ||
|
||
let decryption_properties = FileDecryptionProperties::builder(footer_key.to_vec()) | ||
.disable_footer_signature_verification() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7320.
Rationale for this change
The Parquet format allows encrypting some or all column data while keeping footers in plaintext for compatibility with readers that don't support encryption. See spec.
Arrow-rs already supports reading plaintext footers and writing encrypted parquet files and should also support writing parquet files with plaintext footers.
What changes are included in this PR?
Are there any user-facing changes?
This now enables writing plaintext footers, while in current state attempting to write a plaintext footer would throw an error.