revert the code change, only test move, comment the failed test.

apache · Feb 22, 2025 · 359a5ec · 359a5ec
1 parent 7738768
commit 359a5ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/arrow-cast/src/cast/decimal.rs b/arrow-cast/src/cast/decimal.rs
@@ -603,7 +603,8 @@ mod tests {
             12300000_i128
         );
 
-        assert_eq!(parse_decimal::<Decimal128Type>("123.45", 38, 0)?, 123_i128);
+        // `parse_decimal` does not handle scale=0 correctly. will enable it as part of code change PR.
+        // assert_eq!(parse_decimal::<Decimal128Type>("123.45", 38, 0)?, 123_i128);
         assert_eq!(
             parse_decimal::<Decimal128Type>("123.45", 38, 5)?,
             12345000_i128

diff --git a/arrow-cast/src/parse.rs b/arrow-cast/src/parse.rs
@@ -988,11 +988,6 @@ pub fn parse_decimal<T: DecimalType>(
         }
     }
 
-    //handle scale = 0 , scale down by fractional digits
-    if scale == 0 {
-        result = result.div_wrapping(base.pow_wrapping(fractionals as u32))
-    }
-
     Ok(if negative {
         result.neg_wrapping()
     } else {