move the mod.rs tests for parse_string_to_decimal_native to parse_decimal

Author: himadripal

arrow-cast/src/cast/decimal.rs

@@ -615,7 +615,7 @@ mod tests {
         );
         assert_eq!(
             parse_decimal::<Decimal128Type>("123.4567891", 38, 5)?,
-            12345679_i128
+            12345678_i128
         );
         Ok(())
     }

arrow-cast/src/cast/mod.rs

@@ -2383,6 +2383,7 @@ where
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::parse::parse_decimal;
     use arrow_buffer::{Buffer, IntervalDayTime, NullBuffer};
     use chrono::NaiveDate;
     use half::f16;
@@ -8416,92 +8417,92 @@ mod tests {
     fn test_parse_string_to_decimal() {
         assert_eq!(
             Decimal128Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal128Type>("123.45", 2).unwrap(),
+                parse_decimal::<Decimal128Type>("123.45", 38, 2).unwrap(),
                 38,
                 2,
             ),
             "123.45"
         );
         assert_eq!(
             Decimal128Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal128Type>("12345", 2).unwrap(),
+                parse_decimal::<Decimal128Type>("12345", 38, 2).unwrap(),
                 38,
                 2,
             ),
             "12345.00"
         );
         assert_eq!(
             Decimal128Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal128Type>("0.12345", 2).unwrap(),
+                parse_decimal::<Decimal128Type>("0.12345", 38, 2).unwrap(),
                 38,
                 2,
             ),
             "0.12"
         );
         assert_eq!(
             Decimal128Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal128Type>(".12345", 2).unwrap(),
+                parse_decimal::<Decimal128Type>(".12345", 38, 2).unwrap(),
                 38,
                 2,
             ),
             "0.12"
         );
         assert_eq!(
             Decimal128Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal128Type>(".1265", 2).unwrap(),
+                parse_decimal::<Decimal128Type>(".1265", 38, 2).unwrap(),
                 38,
                 2,
             ),
-            "0.13"
+            "0.12"
         );
         assert_eq!(
             Decimal128Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal128Type>(".1265", 2).unwrap(),
+                parse_decimal::<Decimal128Type>(".1265", 38, 2).unwrap(),
                 38,
                 2,
             ),
-            "0.13"
+            "0.12"
         );
 
         assert_eq!(
             Decimal256Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal256Type>("123.45", 3).unwrap(),
+                parse_decimal::<Decimal256Type>("123.45", 38, 3).unwrap(),
                 38,
                 3,
             ),
             "123.450"
         );
         assert_eq!(
             Decimal256Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal256Type>("12345", 3).unwrap(),
+                parse_decimal::<Decimal256Type>("12345", 38, 3).unwrap(),
                 38,
                 3,
             ),
             "12345.000"
         );
         assert_eq!(
             Decimal256Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal256Type>("0.12345", 3).unwrap(),
+                parse_decimal::<Decimal256Type>("0.12345", 38, 3).unwrap(),
                 38,
                 3,
             ),
             "0.123"
         );
         assert_eq!(
             Decimal256Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal256Type>(".12345", 3).unwrap(),
+                parse_decimal::<Decimal256Type>(".12345", 38, 3).unwrap(),
                 38,
                 3,
             ),
             "0.123"
         );
         assert_eq!(
             Decimal256Type::format_decimal(
-                parse_string_to_decimal_native::<Decimal256Type>(".1265", 3).unwrap(),
+                parse_decimal::<Decimal256Type>(".1265", 38, 3).unwrap(),
                 38,
                 3,
             ),
-            "0.127"
+            "0.126"
         );
     }
 

arrow-cast/src/parse.rs

@@ -988,6 +988,11 @@ pub fn parse_decimal<T: DecimalType>(
         }
     }
 
+    //handle scale = 0 , scale down by fractional digits
+    if scale == 0 {
+        result = result.div_wrapping(base.pow_wrapping(fractionals as u32))
+    }
+
     Ok(if negative {
         result.neg_wrapping()
     } else {