Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-ID : 59160 , fix extracting host for ipv6 address #213

Merged
merged 2 commits into from
Oct 14, 2024
+3 −2
Merged

BUG-ID : 59160 , fix extracting host for ipv6 address #213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a6363
BUG-ID : 59160 , fix extracting host for ipv6 address
FROZENCADET Oct 3, 2024
7c6c127
Ensure indexOfPath is bigger than indexOfAt
FROZENCADET Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,9 @@ private String parseUri(final String uri) {
throw new BuildException("no username was given. Can't authenticate.");
}

final int indexOfPath = uri.indexOf(':', indexOfAt + 1);
if (indexOfPath == -1) {
// For IPv6 address having more than one ":", it should look for the last occurrence
final int indexOfPath = uri.lastIndexof(':');
if (indexOfPath <= indexOfAt) {
throw new BuildException("no remote path in %s", uri);
}

Expand Down