BUG-ID : 59160 , fix extracting host for ipv6 address #213
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodewig
reviewed
Oct 8, 2024
| @@ -435,7 +435,8 @@ private String parseUri(final String uri) { | |||
| throw new BuildException("no username was given. Can't authenticate."); | |||
| } | |||
|
|
|||
| final int indexOfPath = uri.indexOf(':', indexOfAt + 1); | |||
| // For IPv6 address having more than one ":", it should look for the last occurrence | |||
| final int indexOfPath = uri.lastIndexof(':'); | |||
| if (indexOfPath == -1) { | |||
There was a problem hiding this comment.
we should still ensure indexOfPath is bigger than indexOfAt. So maybe we change the if to not only throw if it is -1 but rather if it is less than or equal indexOfAt (equal could be the case if indexOfAt is -1 itself.
There was a problem hiding this comment.
I agree.. have made the required changes
|
@FROZENCADET actually the code didn't even compile see 2540910 Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the last occurrence of ':' while getting the indexOfPath as IPv6 address has more than one ':'.