-
Notifications
You must be signed in to change notification settings - Fork 49
fix: container launch issues #4163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Verified. All changes are working fine. |
Yes, I agree. I came across a specific case related to the last point mentioned here, while working on the parametric workflow example. Fluent was changing current working directory on its own but container was launched with different working directory as a host path. |
@raph-luc, Thanks for the descriptive tests. Looks good 👍 |
@raph-luc Merging to create a release. |
There were issues running Fluent containers through PyFluent introduced at some point since version 0.30.5 (after which the
simba-plugin-fluent
tests started failing). The mount_source/mount_target/working_dir logic was not working properly, see first commit below for test that was showing the failure: 270495dNotes:
fluent_container.py
for more detailsdict_to_str
utility function to provide "pretty printed" string for dicts, also aware of hide log secrets env var for CI runs