Skip to content

fix: container launch issues #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 18, 2025
Merged

Conversation

raph-luc
Copy link
Member

@raph-luc raph-luc commented Jun 13, 2025

There were issues running Fluent containers through PyFluent introduced at some point since version 0.30.5 (after which the simba-plugin-fluent tests started failing). The mount_source/mount_target/working_dir logic was not working properly, see first commit below for test that was showing the failure: 270495d

Notes:

  • Main change: revised mount_source/mount_target logic, see code comments in fluent_container.py for more details
  • Took the opportunity to do some refactoring:
    • New dict_to_str utility function to provide "pretty printed" string for dicts, also aware of hide log secrets env var for CI runs
    • Revised docstring for mount_source/mount_target
  • New test, and test fixes related to this. In summary: we should not assume that the full paths that Fluent sees inside the container match exactly the full paths that PyFluent sees on the host system

@github-actions github-actions bot added the bug Issue, problem or error in PyFluent label Jun 13, 2025
@hpohekar
Copy link
Collaborator

Verified. All changes are working fine.

https://github.com/ansys/pyfluent/actions/runs/15723746346

https://github.com/ansys/pyfluent/actions/runs/15723743336

@hpohekar
Copy link
Collaborator

hpohekar commented Jun 18, 2025

There were issues running Fluent containers through PyFluent introduced at some point since version 0.30.5 (after which the simba-plugin-fluent tests started failing). The mount_source/mount_target/working_dir logic was not working properly, see first commit below for test that was showing the failure: 270495d

Notes:

  • Main change: revised mount_source/mount_target logic, see code comments in fluent_container.py for more details

  • Took the opportunity to do some refactoring:

    • New dict_to_str utility function to provide "pretty printed" string for dicts, also aware of hide log secrets env var for CI runs
    • Revised docstring for mount_source/mount_target
  • New test, and test fixes related to this. In summary: we should not assume that the full paths that Fluent sees inside the container match exactly the full paths that PyFluent sees on the host system

Yes, I agree. I came across a specific case related to the last point mentioned here, while working on the parametric workflow example. Fluent was changing current working directory on its own but container was launched with different working directory as a host path.

@prmukherj
Copy link
Collaborator

@raph-luc, Thanks for the descriptive tests. Looks good 👍

@hpohekar
Copy link
Collaborator

@raph-luc Merging to create a release.

@hpohekar hpohekar merged commit 1fe6cdb into main Jun 18, 2025
99 of 113 checks passed
@hpohekar hpohekar deleted the rluciano/container-and-launch-fixes branch June 18, 2025 08:25
@raph-luc raph-luc restored the rluciano/container-and-launch-fixes branch June 18, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyFluent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants