Skip to content

fix: container timeout issue and new environment variables #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

raph-luc
Copy link
Member

@raph-luc raph-luc commented Jun 16, 2025

Changes:

  • Fixed issue related to the container launcher not recognizing timeout settings coming through launch_fluent. Now the container launcher respects the start_timeout argument, and the container_dict["timeout"] argument is marked as deprecated
  • Now when a container launch times out, it will attempt to stop the container. I noticed during the tests that timeout or failure during launch were causing zombie containers to be left behind. Now that should not happen anymore
  • test_unsuccessful_fluent_connection now works for containers as well and tests that their timeout config is working properly
  • New test_container_timeout_deprecation and test_container_timeout_deprecation_override for testing the deprecation behavior
  • Support for new PYFLUENT_FLUENT_LAUNCH_TIMEOUT and PYFLUENT_FLUENT_AUTOMATIC_TRANSCRIPT env vars - were useful previously for testing/development
  • Convenience env_var_to_bool method to get the value from an env var and return the Boolean that represents it:
    def env_var_to_bool(var_name: str, default: str = "false") -> bool:
    """Converts environment variable to boolean. By default, returns 'False' if the variable is not set."""
    value = os.getenv(var_name, default).strip().lower()
    if value in ("0", "off", "false", "no"):
    return False
    else:
    return True
    • Refactored code to make use of env_var_to_bool where it makes sense

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) bug Issue, problem or error in PyFluent labels Jun 16, 2025
@raph-luc raph-luc force-pushed the rluciano/env-vars-revision branch from 0bd364f to cba8260 Compare June 16, 2025 17:46
Base automatically changed from rluciano/container-and-launch-fixes to main June 18, 2025 08:25
@raph-luc raph-luc force-pushed the rluciano/env-vars-revision branch from dbd3a0f to 1b34713 Compare June 18, 2025 21:02
@raph-luc raph-luc changed the title fix: adding env var and revising treament of boolean env vars fix: container timeout issue and new environment variables Jun 20, 2025
@raph-luc raph-luc force-pushed the rluciano/env-vars-revision branch from e80180e to 2b1af7b Compare June 20, 2025 17:37
@raph-luc raph-luc marked this pull request as ready for review June 20, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyFluent documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant