added some shared code into module_utils/ec2 #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
ec2_utils_0924
branch
from
0fb7241
to
59422b5
Compare
alinabuzachis
approved these changes
Sep 24, 2024
abikouo
force-pushed
the
ec2_utils_0924
branch
from
46e5700
to
2bfb1a5
Compare
abikouo
force-pushed
the
ec2_utils_0924
branch
from
2bfb1a5
to
6e646c1
Compare
|
recheck |
|
regate |
softwarefactory-project-zuul
bot
merged commit 1df898b
into
ansible-collections:main
37 checks passed
braydencw1
pushed a commit
to braydencw1/amazon.aws
that referenced
this pull request
Oct 3, 2024
SUMMARY We need to move some shared code calling AWS API with ec2 client to migrate modules community.aws.ec2_vpc_egress_igw community.aws.ec2_vpc_egress_igw_info community.aws.ec2_vpc_nacl community.aws.ec2_vpc_nacl_info ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/autoscaling Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We need to move some shared code calling AWS API with ec2 client to migrate modules
community.aws.ec2_vpc_egress_igwcommunity.aws.ec2_vpc_egress_igw_infocommunity.aws.ec2_vpc_naclcommunity.aws.ec2_vpc_nacl_infoISSUE TYPE
COMPONENT NAME
module_utils/autoscaling