Refactor ec2_transit_gateway_* modules #2158
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @GomathiselviS could you please provide more details on what changes should be done, I am not sure.
Will be updating imports in migration PR, for refactoring c.aws seems fine. |
You can refer to one of the closed refactoring PRs from @abikouo or @alinabuzachis (https://github.com/ansible-collections/community.aws/pull/2152/files) |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Can you please follow the pattern for refactoring we have adopted in the other PRs (see for example #2152 and ansible-collections/amazon.aws#2302)? We would like to maintain consistency.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
refactor_ec2_transit_gateway_info
branch
from
3786cc5
to
7012f35
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 43s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 23s (non-voting) |
mandar242
force-pushed
the
refactor_ec2_transit_gateway_info
branch
from
80dd53c
to
27275f4
Compare
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 22s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 02s (non-voting) |
SUMMARY Added api calls used by ec2_transit_gateway and ec2_transit_gateway_info to ec2 module_utils Required for ansible-collections/community.aws#2158 ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/ec2 ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 04s (non-voting) |
|
recheck |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 55s (non-voting) |
|
recheck |
|
Build failed.
|
|
recheck |
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 32s (non-voting) |
GomathiselviS
added
mergeit
|
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 11s (non-voting) |
|
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 42s (non-voting) |
softwarefactory-project-zuul
bot
merged commit fc782d2
into
ansible-collections:main
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
SUMMARY Refactor ec2_transit_gateway and ec2_transit_gateway_info modules common code moved to module_utils ansible-collections/amazon.aws#2325 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_transit_gateway ec2_transit_gateway_info ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin
SUMMARY
Refactor ec2_transit_gateway and ec2_transit_gateway_info modules
common code moved to module_utils ansible-collections/amazon.aws#2325
ISSUE TYPE
COMPONENT NAME
ec2_transit_gateway
ec2_transit_gateway_info
ADDITIONAL INFORMATION