Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #2291/14d447b6 backport][stable-8] ec2_vpc_route_table: Add support to configure Transit Gateway routes in route table #2295

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Sep 16, 2024

This is a backport of PR #2291 as merged into main (14d447b).

SUMMARY

Fixes #478
This PR updates the ec2_vpc_route_table "routes" parameter to support the transit gateway id.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

… in route table (#2291)

SUMMARY

Fixes #478
This PR updates the ec2_vpc_route_table "routes" parameter to support the transit gateway id.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
Reviewed-by: GomathiselviS
(cherry picked from commit 14d447b)
Copy link

github-actions bot commented Sep 16, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/145f1eb91e7a42ec97da10c7e1389cf4

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 10m 43s
✔️ ansible-test-splitter SUCCESS in 4m 14s
✔️ integration-amazon.aws-1 SUCCESS in 21m 40s
Skipped 43 jobs

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 18, 2024
SUMMARY

Fix sanity errors occurring with the devel branch of ansible
ERROR: Found 2 pylint issue(s) which need to be resolved:
ERROR: plugins/modules/ec2_vpc_endpoint.py:441:24: used-before-assignment: Using variable 'result' before assignment
ERROR: plugins/modules/ec2_vpc_route_table.py:792:7: used-before-assignment: Using variable 'route_table' before assignment

See #2295

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@alinabuzachis
Copy link
Collaborator

recheck

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2f5abc2e88aa461bb12ca63416373b37

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 11m 02s
✔️ ansible-test-splitter SUCCESS in 4m 21s
✔️ integration-amazon.aws-1 SUCCESS in 22m 03s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Oct 4, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/84472e3eaa3e4d5d9cc68bbd1eab6d5c

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 11m 05s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 22m 07s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 85ad721 into stable-8 Oct 4, 2024
35 of 37 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-8/14d447b6d16411f058c3a463805e5b5781bee9b3/pr-2291 branch October 4, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants