Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanity errors occurring with the devel branch of ansible #2297

Conversation

alinabuzachis
Copy link
Collaborator

@alinabuzachis alinabuzachis commented Sep 18, 2024

SUMMARY

Fix sanity errors occurring with the devel branch of ansible

ERROR: Found 2 pylint issue(s) which need to be resolved:
ERROR: plugins/modules/ec2_vpc_endpoint.py:441:24: used-before-assignment: Using variable 'result' before assignment
ERROR: plugins/modules/ec2_vpc_route_table.py:792:7: used-before-assignment: Using variable 'route_table' before assignment

See #2295

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Signed-off-by: Alina Buzachis <[email protected]>
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7fc74520690149c9ba4b713cba17752d

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 10m 30s
✔️ ansible-test-splitter SUCCESS in 4m 19s
✔️ integration-amazon.aws-1 SUCCESS in 17m 01s
✔️ integration-amazon.aws-2 SUCCESS in 8m 10s
Skipped 42 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side note: these are actually cropping up because the various static analysis tools don't know that fail_json_aws ultimately calls exit().

As we move away from passing module around and using exceptions which we handle in the main() loop, these will start to go away...

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Sep 18, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0100ad30eb904b77aff631d423cf5b9e

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 11m 42s
✔️ ansible-test-splitter SUCCESS in 4m 18s
✔️ integration-amazon.aws-1 SUCCESS in 17m 25s
✔️ integration-amazon.aws-2 SUCCESS in 9m 31s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 13d7be3 into ansible-collections:stable-8 Sep 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants