ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632

taehopark32 · 2023-06-30T14:56:48Z

SUMMARY

Fixes #1618

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

plugins/modules/ec2_vpc_nat_gateway.py

ADDITIONAL INFORMATION

softwarefactory-project-zuul · 2023-06-30T15:49:59Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/50383f8c06e2414e9bfd71946fccfede

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 14m 21s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-amazon.aws-1 SUCCESS in 20m 16s
Skipped 43 jobs

softwarefactory-project-zuul · 2023-07-04T09:17:40Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/02e6969f235f4c17806a0e3f8e72b775

✔️ ansible-galaxy-importer SUCCESS in 4m 34s
✔️ build-ansible-collection SUCCESS in 14m 30s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-amazon.aws-1 SUCCESS in 18m 05s
Skipped 43 jobs

patchback · 2023-07-04T09:17:44Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply afe9ccb on top of patchback/backports/stable-5/afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632

Backporting merged PR #1632 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632 upstream/stable-5

Now, cherry-pick PR ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632 contents into that branch:
```
$ git cherry-pick -x afe9ccb52fa0611607c5a8f19f9454cba86980b3
```
If it'll yell at you with something like fatal: Commit afe9ccb52fa0611607c5a8f19f9454cba86980b3 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x afe9ccb52fa0611607c5a8f19f9454cba86980b3
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2023-07-04T09:17:51Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632

Backported as #1641

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…ivity_type=private (#1632) ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private SUMMARY Fixes #1618 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/ec2_vpc_nat_gateway.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit afe9ccb)

github-actions · 2023-07-04T09:50:49Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

…ivity_type=private (#1632) (#1641) [PR #1632/afe9ccb5 backport][stable-6] ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private This is a backport of PR #1632 as merged into main (afe9ccb). SUMMARY Fixes #1618 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/ec2_vpc_nat_gateway.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

…ivity_type=private (ansible-collections#1632) ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private SUMMARY Fixes ansible-collections#1618 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/ec2_vpc_nat_gateway.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit afe9ccb)

…afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632 [manual backport stable-5] ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private (#1632)

…ons#1632) Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a8cbce2

…ons#1632) Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None>

…ons#1632) Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a8cbce2

Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a8cbce2

…ons#1632) Ansible User-Agent identification for community.aws SUMMARY The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0 ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a8cbce2

taehopark32 added 2 commits June 30, 2023 10:54

changes to no allocate eip address when connectivity_type=private

7433333

added fragment

629c828

taehopark32 changed the title ~~changes to no allocate eip address when connectivity_type=private~~ ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private Jun 30, 2023

alinabuzachis approved these changes Jul 4, 2023

View reviewed changes

alinabuzachis added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory) labels Jul 4, 2023

softwarefactory-project-zuul bot merged commit afe9ccb into ansible-collections:main Jul 4, 2023

patchback bot mentioned this pull request Jul 4, 2023

[PR #1632/afe9ccb5 backport][stable-6] ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1641

Merged

hakbailey mentioned this pull request Jul 4, 2023

[manual backport stable-5] ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private (#1632) #1644

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632

ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632

taehopark32 commented Jun 30, 2023

softwarefactory-project-zuul bot commented Jun 30, 2023

softwarefactory-project-zuul bot commented Jul 4, 2023

patchback bot commented Jul 4, 2023 •

edited

Loading

patchback bot commented Jul 4, 2023 •

edited

Loading

github-actions bot commented Jul 4, 2023

ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632

ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private #1632

Conversation

taehopark32 commented Jun 30, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Jun 30, 2023

softwarefactory-project-zuul bot commented Jul 4, 2023

patchback bot commented Jul 4, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1632 into main

patchback bot commented Jul 4, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

github-actions bot commented Jul 4, 2023

Docs Build 📝

patchback bot commented Jul 4, 2023 •

edited

Loading

patchback bot commented Jul 4, 2023 •

edited

Loading