Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual backport stable-5] ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private (#1632) #1644

Conversation

hakbailey
Copy link
Contributor

[manual backport stable-5] ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private (#1632)

ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private

SUMMARY

Fixes #1618

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

plugins/modules/ec2_vpc_nat_gateway.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit afe9ccb)

@hakbailey hakbailey marked this pull request as draft July 4, 2023 14:40
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/742ed60a6a0547f2887965ceec52601e

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 13m 19s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 19m 47s
Skipped 43 jobs

@hakbailey
Copy link
Contributor Author

Waiting for #1645 to merge so all checks can be run on this.

…ivity_type=private (ansible-collections#1632)

ec2_vpc_nat_gateway - changes to no allocate eip address when connectivity_type=private

SUMMARY

Fixes ansible-collections#1618

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

plugins/modules/ec2_vpc_nat_gateway.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit afe9ccb)
@hakbailey hakbailey force-pushed the patchback/backports/stable-5/afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632 branch from bce0d50 to c6fa7e1 Compare July 5, 2023 15:54
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1b344d64cbee40c79517d3a4a24e30a1

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 13m 09s
✔️ ansible-test-splitter SUCCESS in 5m 09s
✔️ integration-amazon.aws-1 SUCCESS in 19m 30s
Skipped 43 jobs

@hakbailey hakbailey marked this pull request as ready for review July 5, 2023 16:46
@hakbailey hakbailey merged commit 4df5c44 into ansible-collections:stable-5 Jul 5, 2023
39 checks passed
@hakbailey hakbailey deleted the patchback/backports/stable-5/afe9ccb52fa0611607c5a8f19f9454cba86980b3/pr-1632 branch July 5, 2023 17:53
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
ssm_parameter - fix typo in docs

SUMMARY
ssm_parameter - fix typo in docs
paramater instead of parameter
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ssm_parameter
ADDITIONAL INFORMATION
Fixes: ansible-collections#1642

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
ssm_parameter - fix typo in docs

SUMMARY
ssm_parameter - fix typo in docs
paramater instead of parameter
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ssm_parameter
ADDITIONAL INFORMATION
Fixes: ansible-collections#1642

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
ssm_parameter - fix typo in docs

SUMMARY
ssm_parameter - fix typo in docs
paramater instead of parameter
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ssm_parameter
ADDITIONAL INFORMATION
Fixes: ansible-collections#1642

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants