Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/icon): mat-icon misaligned when text-spacing is applied #29686

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(material/icon): mat-icon misaligned when text-spacing is applied #29686

wants to merge 4 commits into from

Commits on Sep 18, 2024

  1. fix(material/icon): mat-icon misaligned when text-spacing is applied 

    Fixes an issue with Angular Components Material Icon component where
when text-spacing is applied the icon gets misaligned and if inside
of an input or container with an outline, the icon gets cut off.
This fix adds css styling  to keep the icon
middle-aligned when text-spacing is applied.

Fixes b/250063405
    @essjay05
    essjay05 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6f7e1e1 View commit details
    Browse the repository at this point in the history

  2. fix(material/icon): changes overflow to visible for button icon 

    Updates styles for Angular Material Icon so when the icon is
within a button it sets the overflow to visible to avoid the
icon from being cutoff. Also updates the line-height to 1 set

Fixes b/250063405
    @essjay05
    essjay05 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cf37ddf View commit details
    Browse the repository at this point in the history

  3. refactor(material/icon): moves styles to bottom of scss file 

    Updates previous fix to move added styles to bottom of scss
file for overriding.

Fixes b/250063405
    @essjay05
    essjay05 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    45e70d5 View commit details
    Browse the repository at this point in the history

  4. fix(material/icon): updates to include .mat-icon variants 

    Updates classes to target .mat-icon usage in other Angular
Material Components (ie. list-item, list-option, grid-tile,
form-field, tab, toolbar, and tooltip).

Fixes b/250063405
    @essjay05
    essjay05 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c2f58cf View commit details
    Browse the repository at this point in the history