fix(material/icon): mat-icon misaligned when text-spacing is applied #29686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
amysorto and
andrewseguin
and removed request for
a team
jelbourn
added
the
dev-app preview
|
Deployed dev-app for c2f58cf to: https://ng-dev-previews-comp--pr-angular-components-29686-dev-jyg9okrc.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
fix-text-spacing-cutoff-icon
branch
from
8527fc2
to
2030bac
Compare
essjay05
force-pushed
the
fix-text-spacing-cutoff-icon
branch
3 times, most recently
from
9d4ca07
to
e516f0a
Compare
Fixes an issue with Angular Components Material Icon component where when text-spacing is applied the icon gets misaligned and if inside of an input or container with an outline, the icon gets cut off. This fix adds css styling to keep the icon middle-aligned when text-spacing is applied. Fixes b/250063405
Updates styles for Angular Material Icon so when the icon is within a button it sets the overflow to visible to avoid the icon from being cutoff. Also updates the line-height to 1 set Fixes b/250063405
Updates previous fix to move added styles to bottom of scss file for overriding. Fixes b/250063405
Updates classes to target .mat-icon usage in other Angular Material Components (ie. list-item, list-option, grid-tile, form-field, tab, toolbar, and tooltip). Fixes b/250063405
essjay05
force-pushed
the
fix-text-spacing-cutoff-icon
branch
from
e516f0a
to
c2f58cf
Compare
|
It seems like this causes the icons to bleed out from the button: Is there a way that we can undo the text spacing just on icons instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with Angular Components Material Icon component where when text-spacing is applied the icon gets misaligned and if inside of an input or container with an outline, the icon gets cut off. This fix adds css styling to keep the icon middle-aligned when text-spacing is applied.
BEFORE screenshot
AFTER screenshot
AFTER screencast
Fixes b/250063405