Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changelog entry and version modification for vesting #642

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

joemonem
Copy link
Contributor

@joemonem joemonem commented Nov 19, 2024

Motivation

Make versioning format consistent. Add changelog entry for this PR

Implementation

Version went from 3.0.4-beta to 3.0.4-b.1

Testing

None

Version Changes

Version went from 3.0.4-beta to 3.0.4-b.1

Notes

None

Future work

None

Summary by CodeRabbit

  • New Features

    • Introduced several new ADOs: Curve ADO, IBC Registry ADO, and MultiSig ADO.
    • Added functionalities for Denom Validation in IBC Registry ADO and Kernel ICS20 Transfer with optional ExecuteMsg.
    • Implemented IBC Denom Wrap/Unwrap and recipient validation for VFS paths.
    • Added a deployment script and CI workflow for OS, along with deployable interfaces for all ADOs.
  • Bug Fixes

    • Enhanced validation during vesting instantiation and fixed a precision issue in the vesting claim batch method.
    • Resolved validator staking distribution message issues for the Andromeda chain.
  • Chores

    • Updated the CHANGELOG.md to reflect these changes and removed schemas from tracking.

Copy link
Contributor

coderabbitai bot commented Nov 19, 2024

Walkthrough

The pull request introduces several notable changes documented in the CHANGELOG.md, including the addition of new ADOs such as Curve ADO, IBC Registry ADO, and MultiSig ADO. It also includes new functionalities like Denom Validation and Kernel ICS20 Transfer. Modifications to the vesting contract are made, including the removal of staking and adjustments to the vesting logic. Additionally, a version update is applied to the Cargo.toml file for the andromeda-vesting package. Overall, the changes enhance functionality and reliability within the Andromeda core project.

Changes

File/Directory Change Summary
CHANGELOG.md Added new ADOs (Curve, IBC Registry, MultiSig), functionalities (Denom Validation, Kernel ICS20 Transfer, IBC Denom Wrap/Unwrap, Recipient validation for VFS paths), deployment script/CI workflow, and deployable interfaces for ADOs. Removed schemas from tracking.
contracts/finance/andromeda-vesting/Cargo.toml Updated package version from 3.0.4-beta to 3.0.4-b.1. No changes to dependencies or features.

Possibly related PRs

Suggested labels

ci: skip-changelog

Suggested reviewers

  • crnbarr93
  • SlayerAnsh
  • cowboy0015

Poem

In the land of code where bunnies play,
New ADOs hop in, brightening the day.
Vesting logic refined, with no more stake,
A changelog updated, for all our sake.
So let’s celebrate with a joyful cheer,
For every change brings us closer, my dear! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 31a3dce and c5fc704.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • contracts/finance/andromeda-vesting/Cargo.toml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • contracts/finance/andromeda-vesting/Cargo.toml
🔇 Additional comments (1)
CHANGELOG.md (1)

86-86: LGTM! The changelog entry is well-formatted and properly documented.

The entry follows the Keep a Changelog conventions and is correctly placed in the "Fixed" section.

Let's verify the referenced PR:

✅ Verification successful

PR #641 exists and is merged, confirming the changelog entry's accuracy

The referenced PR #641 has been verified:

  • Merged on November 19, 2024
  • State: MERGED
  • Title indicates a fix related to message validation timing
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that PR #641 exists and is merged
gh pr view 641 --json state,title,mergedAt

Length of output: 158


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants