Release 3 Changelog and Backport tags #676
Conversation
crnbarr93
added
ci: skip-changelog
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
12-15: Consider removing empty sections from "Unreleased"Since this PR is focused on Release 3, consider removing the empty "Changed" and "Fixed" sections from "Unreleased" unless there are imminent changes planned. Empty sections can make the changelog harder to scan.
### Added -### Changed - -### Fixed -
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
.github/mergify.yml(1 hunks)CHANGELOG.md(1 hunks)contracts/finance/andromeda-validator-staking/Cargo.toml(2 hunks)contracts/finance/andromeda-vesting/Cargo.toml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- contracts/finance/andromeda-vesting/Cargo.toml
🔇 Additional comments (3)
.github/mergify.yml (1)
16-23: LGTM! The new backport rule follows best practices.
The rule is well-structured and maintains consistency with the existing backporting pattern. It correctly inherits the default assignees configuration and uses appropriate conditions for automated backporting.
contracts/finance/andromeda-validator-staking/Cargo.toml (1)
3-3: LGTM: Version update from beta to stable
The version change from "0.3.0-b.1" to "0.3.0" appropriately reflects the transition to a stable release.
CHANGELOG.md (1)
Line range hint 1-641: Overall changelog structure looks good!
The changelog follows the Keep a Changelog format consistently, with proper categorization and PR links for traceability.
| - name: backport to release/3 branch | ||
| conditions: | ||
| - base=development | ||
| - label=backport/release/3 | ||
| actions: | ||
| backport: | ||
| branches: | ||
| - release/3 |
There was a problem hiding this comment.
💡 Codebase verification
Based on the repository scan results, I can now provide a final response regarding the release/3 branch configuration:
The release/3 branch does not exist in the repository
The git remote check shows only the development branch exists, and there are no references to a release/3 branch in the codebase. The mergify configuration attempting to backport to a non-existent branch would fail.
🔗 Analysis chain
Verify the target branch configuration.
Let's ensure the target branch exists and has appropriate permissions set up.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the release/3 branch exists and has appropriate protection rules
# Check if the branch exists
git ls-remote --heads origin release/3
# Check branch protection rules using GitHub API
gh api repos/:owner/:repo/branches/release/3/protection
Length of output: 319
Script:
#!/bin/bash
# Let's check the existing branches and their recent activity
git branch -r
# Check if there are any references to release/3 in the repository
rg -i "release/3" -g "!.git"
# Let's also check the README or documentation for any mention of branch strategy
fd -g "README*" -X cat {}
Length of output: 52598
| cw-orch-daemon = "0.24.2" |
There was a problem hiding this comment.
💡 Codebase verification
Workspace versioning should be implemented for cw-orch-daemon
The workspace is properly configured with [workspace.dependencies] section, but cw-orch-daemon is missing from it. Multiple versions (0.24.2 and 0.24.3) are currently used across different packages, which could lead to compatibility issues.
- Add
cw-orch-daemonto workspace dependencies in rootCargo.toml - Update all package-level dependencies to use workspace versioning
- Consider upgrading to the latest version 0.28.1 after checking for breaking changes
Example fix:
# In root Cargo.toml [workspace.dependencies]:
cw-orch-daemon = "0.24.3" # or "0.28.1" after checking compatibility
# In package Cargo.toml files:
cw-orch-daemon = { workspace = true }🔗 Analysis chain
Consider using workspace versioning for cw-orch-daemon
The newly added dependency uses a fixed version which could lead to version inconsistencies across the workspace and potential security vulnerabilities if not maintained.
Run this script to check for the latest version and any potential security advisories:
Consider using workspace versioning like other dependencies:
-cw-orch-daemon = "0.24.2"
+cw-orch-daemon = { workspace = true }Multiple versions of cw-orch-daemon found across workspace, needs standardization
packages/andromeda-testing-e2euses version 0.24.3- All other packages use version 0.24.2
- Latest version available is 0.28.1
Let me verify if workspace dependencies are already set up to determine the best recommendation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify cw-orch-daemon version and usage across workspace
# Check if cw-orch-daemon is defined in workspace dependencies
rg '"cw-orch-daemon"' -A 1 Cargo.toml
# Find all usages of cw-orch-daemon in workspace
rg 'cw-orch-daemon = ".+"'
# Check latest version from crates.io
curl -s https://crates.io/api/v1/crates/cw-orch-daemon | jq -r '.crate.max_version'
Length of output: 732
Script:
#!/bin/bash
# Check if workspace dependencies are defined in root Cargo.toml
rg '\[workspace\.dependencies\]' -A 30 Cargo.toml
# Check if there's a workspace definition that includes these packages
rg '\[workspace\]' -A 10 Cargo.toml
Length of output: 1713
Motivation
Adds mergify support for release 3 backporting and fixes the changelog for release 3
Summary by CodeRabbit
New Features
release/3branch.Bug Fixes
Documentation
Chores
andromeda-validator-stakingandandromeda-vestingpackages to indicate stable releases.