fix: move msg validation to after ADOContract init

[joemonem]

Motivation

Setting vfs path as recipient during Init in vesting ADO was failing because the validation was fetching kernel address before it became available.

Implementation

Moved message validation to after ADOContract::default().instantiate

Testing

None

Version Changes

vesting: 3.0.3-beta -> 3.0.4-beta

Notes

None

Future work

None

Summary by CodeRabbit

• New Features

  • Updated the version of the andromeda-vesting package to 3.0.4-beta.
  • Enhanced safety in the contract's instantiate function by cloning fields before assignment.

• Bug Fixes

  • Improved validation flow by ensuring configuration is established before validation checks in the instantiate function.

• Refactor

  • Maintained existing logic in the execute, execute_claim, and execute_claim_all functions while ensuring proper error handling and compliance with contract rules.

[coderabbitai]

Walkthrough

The changes in this pull request involve an update to the version number of the andromeda-vesting package in the Cargo.toml file, changing it from "3.0.3-beta" to "3.0.4-beta". Additionally, modifications were made to the instantiate function in the contract.rs file, specifically regarding the handling of the recipient and denom fields, which are now cloned before assignment. The validation of the msg object is now performed after saving the configuration. Other functions within the contract maintain their existing logic.

Changes

File Path	Change Summary
contracts/finance/andromeda-vesting/Cargo.toml	Updated package version from 3.0.3-beta to 3.0.4-beta.
contracts/finance/andromeda-vesting/src/contract.rs	Modified instantiate function to clone recipient and denom fields; validation of msg now occurs post-configuration. Other functions (execute, migrate, query, reply) have updated internal logic but unchanged signatures.

Possibly related PRs

• fix: added validation to vesting Instantiate message #583: The changes in this PR involve adding validation to the instantiate function in the andromeda-vesting contract, which directly relates to the modifications made in the main PR regarding the handling of the InstantiateMsg.

Suggested labels

ci: skip-changelog

Suggested reviewers

• crnbarr93

Poem

In the garden where contracts bloom,
A version change dispels the gloom.
With fields now cloned, safety's embraced,
In the world of code, we quicken our pace.
Hops of logic, leaps of grace,
Andromeda shines in its rightful place! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0453364 and 6dfd2a1.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

• contracts/finance/andromeda-vesting/Cargo.toml (1 hunks)
• contracts/finance/andromeda-vesting/src/contract.rs (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• contracts/finance/andromeda-vesting/Cargo.toml

🔇 Additional comments (3)

contracts/finance/andromeda-vesting/src/contract.rs (3)

39-40: LGTM: Defensive cloning of config values

The cloning of recipient and denom values before assignment is a good practice to prevent ownership issues.

---

54-55: LGTM: Consistent defensive cloning

The cloning of kernel_address and owner values maintains consistency with the defensive programming approach used earlier.

---

59-60: LGTM: Fixed validation timing issue

Moving the msg validation after ADOContract initialization correctly resolves the issue where vfs path validation was failing due to unavailable kernel address.

Let's verify that no other validation calls exist in the instantiate flow:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.