Glass protection barrier rework

[IIHERO4]

ReImplement how explosives are treated overall, focusing on TNT bug #292.
IMPORTANT NOTES:

• This is completely untested, I didnt have anytime to test every version but it should work on theory
• 1.17 and 1.18 Version support is not implemented yet, so it needs some work from another person to copy the NMS implementation
• 1.17 and 1.18 calculateExplosionBlocks will throw an error (because its not implement ofc)
• when calculateExplosionBlocks is not implement in the BedWars.nms, it will use simple block detection methods such as isProtectedByGlass and Arena#isPlacedBlock (the acutal events will catch the error and perform alternatives)
• Event BlockExplodeEvent uses the same simple detection methods as stated above

This creates four new methods to VersionSupport and NMS support:

• public List<Block> calculateExplosionBlocks(IArena arena, Entity source, Location explosionLocation, float radius, boolean fire) ¹
• public abstract List<Block> calculateExplosionBlocks(IArena arena, Entity source, Location explosionLocation, float radius, boolean fire, BiFunction<Location, Block, Boolean> callback) ²
• public boolean isGlass(Material type)
• public boolean isProtectedByGlass(Location pov, Block block) ³

Config Added explosion-settings.explosion-size, Possible Values: auto | {Any Number}

Footnotes

1. Uses calculateExplosionBlocks(IArena arena, Entity source, Location explosionLocation, float radius, boolean fire, BiFunction<Location, Block, Boolean> callback) but with a predefined callback that is cached and made specifically for arenas ↩

2. Mostly copied from its respective version Explosion NMS class, acts just like the vanilla one but with more control over the calculation of the exploded blocks ↩

3. Performs a simple ray tracing to check whether the POV and the block have any glass block in between them ↩

[IIHERO4]

needs testing and a look from an actual dev 💀

[IIHERO4]

New Issue has appeared (isProtectedGlass) particularly when iterating using BlockIterator some situations it doesnt work Example:

When placing the tnt instead of the green wool, the red wool gets destroyed
when observing the path BlockIterator takes, it make sense:

As When plugging the parameters, the direction vector is (1, 0, -1) which generates this zigzag pattern

Really need some help on this one [SOLVED]

[LolFin2022]

Me nub.. So no help ;)

[tomkeuper]

Note that currently the only supported versions are: 1_8_R3, 1_12_R1, 1_16_R3, 1_17_R1, 1_18_R2 and 1_19_R2
Version support for other version could/should be removed

[tomkeuper]

Once 1.19 support is implented and the other not supported versions are removed we could give this pr a shot.

[tomkeuper]

    // Copied from Explosion#a() (The NMS implementation of https://minecraft.fandom.com/wiki/Explosion#Model_of_block_destruction)

[andrei1058]

What's the impact on the main thread tho?

[IIHERO4]

I should note that In some cases this fails and over protect it as in the ray casting is too fat for example a block that is protected from one side and not the other will get protected because we check for the "components" of the ray
(B = block, G = glass, A = air, T = tnt)

B G
A T

ray checking:
R x
y (Since x hits G so its "protected")

I cant really work out a fix for this.

a second note is that i believe you could try to do it inside the NMS implementation itself instead of calling isProtected but i just didnt bother after couple of tries

[IIHERO4]

What's the impact on the main thread tho?

as far as im using it, it has close to none but you could tweak the "step" param to make less checks

[andrei1058]

I think it would be better to add NBT data on the entity, so we can avoid involving a new cache cleaner thread.