Fireball Enhancement #804
Closed
Fireball Enhancement #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to sphere, supporting area protection
…oy the original blocks on the map
|
Isn't this related to #469 ? We should implement the protection logic for fireballs there. |
Now it has not achieved support for explosion-proof glass |
Do you mean that this PR lacks support for explosion-proof glass? |
|
The other pull request will also protect cumstom areas such as shop etc. Fireballs are explosions, so in the end I think I will implement your logic in the other pull request to make it cleaner. |
So it won't be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fireball can now destroy blocks and supports the following functions