Sign extend AD4170 data when channels are in bipolar configuration #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ADC output code is two's complement when the channel setup has the bipolar field configured in the AFE register. Sign extend ADC data when the channel is in bipolar configuration. Signed-off-by: Marcelo Schmitt <[email protected]>
|
|
buha
approved these changes
Nov 21, 2024
10 tasks
|
Hello @jansunil , can you have a look at this bug fix? |
jansunil
approved these changes
Nov 22, 2024
SaikiranGudla
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to reports, "the AD4170 drivers don't do a sign extension when reading the ADC registers, as the ADC is
24 bits, but the int variable is 32-bit, it fills the 4th bit with zeroes even if bit 23 is 1."
The ADC output code is two's complement when the channel setup has the bipolar field configured in the AFE register.
Sign extend ADC data when the channel is in bipolar configuration.