Add IIO support for AD4170 #2363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of AD4170 registers will also be useful for follow up patches implementing debugfs IIO support AD4170. Declare AD4170 register list in AD4170 header file so it can be reused by IIO support routines. Signed-off-by: Marcelo Schmitt <[email protected]>
machschmitt
force-pushed
the
staging/ad4170_iio
branch
from
c7fb039 to
dbeb7ae
Compare
Add basic IIO support for voltage read and register access for debug purposes. Signed-off-by: Marcelo Schmitt <[email protected]>
machschmitt
force-pushed
the
staging/ad4170_iio
branch
from
dbeb7ae to
a8c48c5
Compare
|
The fix for the data sign extension was implemented in the precision-converters-firmware repo (https://github.com/analogdevicesinc/precision-converters-firmware). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The reported issue is the following: "The AD4170 drivers don't do a sign extension when reading the ADC registers, as the ADC is 24 bits, but the int variable is 32-bit, it fills the 4th bit with zeroes even if bit 23 is 1."
While that could be fixed in the base driver by checking the bipolar field of AFE register in
ad4170_get_ch_data(), I believe it's better to support the bipolar/unipodar data configuration through IIO so truly raw data access is preserved through the base driver channel read function.Add support for basic IIO support that will output
_rawdata that is properly signed according to the bipolar/unipolar AFE configuration.PR Type
PR Checklist