Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add tonemapped generator #92

Open
wants to merge 10 commits into
base: feature/add_clipping_filter
Choose a base branch
from
Open

Feature/add tonemapped generator #92

wants to merge 10 commits into from

Commits on Sep 3, 2024

  1. We move the project field names into the constant vs scattering them … 

    …in the code

We add a unit test for this
We default cleanup to be true, as otherwise machines get filled up quickly
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a0b510c View commit details
    Browse the repository at this point in the history

  2. Update the base generators sort function so that rather than hard cod… 

    …e the start_index we can override this from other generators if needed

We also return the indicies so this can be used to extend the function further
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f1c26fd View commit details
    Browse the repository at this point in the history

  3. We ensure that the GeneratorName is stored in the clf file along with… 

    … the other settings
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2d3ad33 View commit details
    Browse the repository at this point in the history

  4. We exclude the schema_version by constant but also the DATA paths aga… 

    …in using constants
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6b7b162 View commit details
    Browse the repository at this point in the history

  5. Doc string and return the clipped_indicies from the remove_clipping f… 

    …unction so could be extended
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d628d42 View commit details
    Browse the repository at this point in the history

  6. If somehow we end up with all of our exposures clipping the throw an … 

    …error
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c505225 View commit details
    Browse the repository at this point in the history

  7. Add a TODO query regarding the k value being written into the clf

    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2c7c1b2 View commit details
    Browse the repository at this point in the history

  8. Add the remove clipping to the application and the app. Also a TODO a… 

    …s this execution order should not be controlled via the UI
    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    760863a View commit details
    Browse the repository at this point in the history

  9. Added tonemapped_idt generator and helper functions.

    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6cf4d21 View commit details
    Browse the repository at this point in the history

  10. Seperate the process logic from the process_archive

    @davisadam10
    davisadam10 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7482e3f View commit details
    Browse the repository at this point in the history