Energy Conserving P2 Can-pb Colls Fix #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…integrated moment only outputs the integrated energy
…rgy moments for can-pb
…ed [density, momentum, energy]
…hich means main does not build on GPUs. After some digging, I think this bug appeared when the wv_eqn functions were modified to uniformly take the wv_eqn object (so things like the mixture formalism know how many components to rotate). I think when this change occurred that introduced too many indirections on GPUs and the GPU started throwing the nvlink errors we've seen before that always arise when the GPU has completely crapped out on handling the layering Gkeyll does. Testing to see if removing a layer of indirection helps.
… inside the equation object, we just directly call the function in the private header for the individual wv_eqn objects. Please for the love of CUDA gods work
…hods now because we can call them from both host and device code
… to clean it up and prevent lots of unused variable warnings (since now this header file is being directly utilized by kernels).
JunoRavin
approved these changes
Oct 8, 2024
JonathanGorard
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the detailed design review: Here.
PR Summary:
Verified:
[X] Builds and runs on GPUs
[X] CPU tests are valgrind clean