Add missing multiplication by bmag in GKYL_PROJ_FUNC of gk_species_projection #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the all_gather method. Need to add MPI to a couple of GK regression tests to make sure this is working
…, M1, M2) instead of primitive moments (n, u, T). This option facilitates the use of correct_maxwellian_gyrokinetic, which corrects the lab moments to be the desired input lab moments.
…this 2x2v simulation that it completely garbles the electron moments.
… delete before merge but first let's get this working.
Modify dg_diffusion_gyrokinetic so the inner most derivative is on f, not J*f. Tested in a 2x2v step simulation and produces results visually identical to simulations with old diffusion operator.
… with argon species. Still need to add feature to run with static neutrals.
…since earlier anomaly is gone. Note for future: I think the ref temp is too high.
… time and can just provide a source via ionization
…ct_neut struct instead of react in gk species in the regression test so that react->all_gk gets set correctly
… operates on because it needs to be operating on a sub-range of the global range so that we can correctly index the global field (the charge density)
…ts to ensure factors are floats, not ints
…ow still not being applied in regression tests, though.
…rsion seemed ok. Also get rid of some unnecessary steps. Not tested on GPU yet.
…_op was trying to divide by components > 0 of jacobgeo.
…al tests that I have merged into one 2x2v step test that runs in < 1 minute including geometr initialization. I have removed the 3x2v test because it was really a pseudo-2x test with 1 cell in y. If someone wants an example for 3x SOL turbulence they should see the solovev test instead. I don't know what to do with regression tests that have reactions because I'm not sure if the user will always have ADAS installed/how that should work. I will leave STEP regression tests with reactions untouched until I know th answer to this.
…exponential may overflow. Will next add similar protections (along with the base level protections) that are not present in maxwellian projection
Gk g0 app maxproj protections
…the GKYL_PROJ_FUNC option in gk_species_projecton. In g2 we multiplied by jacobtot, while here we separately multiplying by bmag and jacobgeo. Unclear whether this matters, but at least multiplying by bmag somehow is an improvement. Rename some variables in gk_lbo_relax test for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed since we wish to evolve jacobgeobmagf