Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEM Poisson signature changed so need to adjust the regression test of FEM Poisson timing. #202

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

JunoRavin
Copy link
Collaborator

No description provided.

@manauref
Copy link
Collaborator

@JunoRavin
FYI to avoid future bugs
The following code

  struct gkyl_array *epsilon = mkarr1(use_gpu, basis.num_basis, localRange_ext.volume);
  gkyl_array_shiftc(epsilon, 1.0, 0);

is not equivalent to setting epsilon to 1. We need

  gkyl_array_shiftc(epsilon, 1.0*pow(sqrt(2.),basis.ndim), 0);

to take care of the normalization

@manauref
Copy link
Collaborator

also not ideal that no objects are released in this reg test. But maybe it's ok since it's such a small program

@manauref manauref merged commit 2f41f57 into main Sep 13, 2023
2 checks passed
@manauref manauref deleted the fix-fem-regression branch September 14, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants