Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fem_poisson: take the solve_range as an input, and expect epsilon as a gkyl_array #201

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

manauref
Copy link
Collaborator

  1. Make fem_poisson take solve_range as an input, rather than constructing it inside. It is better to have the driver program define the ranges in which operations are performed. This was done in fem_poisson_perp and fem_parproj to allow parallel operations; it is strictly not necessary for fem_poisson since this operation always happens on the whole grid, but it keeps this updater in line with the others.
  2. Change the signature so that epsilon is specified as a gkyl_array. In the case of constant epsilon, we expect that the gkyl_array contains the DG representation of that constant value. We later do other things inside to make it efficient and not deal with the a whole-grid DG field (in the constant epsilon case).

…or parallel poisson solves (needed for VP and 2x GK). Also change the signature so it now always expects epsilon to be given as a gkyl_array, and users can say if it's constant via is_epsilon_constant. This is all so we can define rhs_cellavg with the correct size, which is not solve_range.volume but rather epsilon->size. Also change fem_poisson_perp so that rhs_cellavg has the right size. Unfortunately the latter continues to be broken for periodic BCs, there's z dependence where there should be none (will deal with that in some future).
… the epsilon array stored in the updater was wrong for the constant epsilon case. Somehow it only manifested itself when I ran on stellar-amd, but not on my laptop.
@ammarhakim ammarhakim merged commit 3da8f90 into main Sep 12, 2023
2 checks passed
@manauref manauref deleted the fem_poisson_par branch September 12, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants