Remove p=2 fem_poisson_perp kernels #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. We'll likely just change the Poisson solver to work on planes, which will reduce kernel size for p=2. Unit tests for p=1 still pass.
…r but that may be an issue with something else (maybe my Mac/environment).
manauref
requested review from
JunoRavin,
ammarhakim,
tnbernard,
akashukla and
tmqian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gkylcas 5bd72f6cd7c073fd1534a5bc929404ac6ba3de41
Removing these kernels because they take too long to build (especially on GPUs). We'll limit ourselves to p=1 for now; in the future we may change the solver to work on planes instead, which will reduce kernel size for all p.
p=1 unit tests still pass (on CPU at least).
Also fix the use of fem_poisson in one of the regression tests.