Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ...since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #90

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix: ...since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #90

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec39c89
Update RNRSA.swift
docvhcm Sep 22, 2020
cec7d24
Update RNRSAKeychain.swift
docvhcm Sep 22, 2020
01540fb
Upgrade spongycastle
docvhcm Sep 22, 2020
fafd684
Fix: Duplicated classes found in modules
docvhcm Sep 23, 2020
51742fe
Update build.gradle
docvhcm Sep 23, 2020
b8455dd
Update build.gradle
docvhcm Sep 23, 2020
4d8277d
Update build.gradle
docvhcm Jun 24, 2022
48f0d62
Update build.gradle
docvhcm Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ buildscript {
}

dependencies {
classpath("com.android.tools.build:gradle:3.5.3")
classpath("com.android.tools.build:gradle:4.0.1")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we leave out the gradle change?
I'm not sure if there are any implications from this, but it is also not related to the PR

}
}
}
Expand Down
5 changes: 5 additions & 0 deletions ios/RNRSA.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import Foundation
@objc(RNRSA)
class RNRSA: NSObject {

@objc
static
func requiresMainQueueSetup() -> Bool {
return false
}

@objc
func constantsToExport() -> [AnyHashable : Any]! {
Expand Down
5 changes: 5 additions & 0 deletions ios/RNRSAKeychain.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import Foundation
@objc(RNRSAKeychain)
class RNRSAKeychain: NSObject {

@objc
static
func requiresMainQueueSetup() -> Bool {
return false
}

@objc
func constantsToExport() -> [AnyHashable : Any]! {
Expand Down