Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ...since it overrides constantsToExport but doesn't implement requiresMainQueueSetup #90

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ buildscript {
if (project == rootProject) {
repositories {
google()
jcenter()
// jcenter()
maven {
url "https://maven.fabric.io/public"
}
mavenCentral()
}

dependencies {
classpath("com.android.tools.build:gradle:3.5.3")
classpath("com.android.tools.build:gradle:4.0.1")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we leave out the gradle change?
I'm not sure if there are any implications from this, but it is also not related to the PR

}
}
}
Expand Down Expand Up @@ -45,7 +45,7 @@ allprojects {
repositories {
mavenLocal()
google()
jcenter()
// jcenter()
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url "$rootDir/../node_modules/react-native/android"
Expand All @@ -55,8 +55,8 @@ allprojects {

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation 'com.madgag.spongycastle:core:1.56.0.0'
implementation 'com.madgag.spongycastle:prov:1.56.0.0'
implementation 'com.madgag.spongycastle:bcpkix-jdk15on:1.56.0.0'
// implementation 'com.madgag.spongycastle:core:1.56.0.0'
// implementation 'com.madgag.spongycastle:prov:1.56.0.0'
// implementation 'com.madgag.spongycastle:bcpkix-jdk15on:1.56.0.0'
}

5 changes: 5 additions & 0 deletions ios/RNRSA.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import Foundation
@objc(RNRSA)
class RNRSA: NSObject {

@objc
static
func requiresMainQueueSetup() -> Bool {
return false
}

@objc
func constantsToExport() -> [AnyHashable : Any]! {
Expand Down
5 changes: 5 additions & 0 deletions ios/RNRSAKeychain.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import Foundation
@objc(RNRSAKeychain)
class RNRSAKeychain: NSObject {

@objc
static
func requiresMainQueueSetup() -> Bool {
return false
}

@objc
func constantsToExport() -> [AnyHashable : Any]! {
Expand Down