Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(externals): sanatize external name #563

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

dogpatch626
Copy link
Contributor

Provide a general summary of your changes in the Title above.

Description

Describe your changes in detail

esbuild would not correctly generate stats file for external if it was scoped.
to fix this sanitizing the string for / and replacing it with - is needed.

This project only accepts pull requests related to open issues.

If suggesting a new feature or change, please discuss it in an issue first.

Motivation

Why is this change required? What issue does it resolve?

Test Conditions

Describe in detail how the changes are tested.

Include details of your testing environment, and the tests you ran to.

How does your change affect the rest of the code.

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

@dogpatch626 dogpatch626 requested review from a team as code owners September 15, 2023 18:08
@JAdshead JAdshead enabled auto-merge (squash) September 15, 2023 18:30
@JAdshead JAdshead requested a review from a team September 15, 2023 18:30
@JAdshead JAdshead merged commit 4be6f3b into main Sep 15, 2023
6 checks passed
@JAdshead JAdshead deleted the fix/externals-esbuild branch September 15, 2023 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants