fix(externals): sanatize external name (#563)

* fix(externals): sanatize external name

* fix(externals): address comment

packages/one-app-dev-bundler/__tests__/esbuild/plugins/time-build.spec.js

@@ -91,7 +91,28 @@ describe('Esbuild plugin timeBuild', () => {
         expect(fs.promises.writeFile).toHaveBeenCalledTimes(1);
         expect(fs.promises.writeFile).toHaveBeenCalledWith('.esbuild-stats.mockBundleName.json', '{"file.js":{},"durationMs":3}');
       });
+      it('should sanatize bundlename replacing `/` with `-`', async () => {
+        const plugin = timeBuild({ bundleName: '@scoped/mockBundleName', watch: false });
+        const hooks = runSetupAndGetLifeHooks(plugin);
+        const onStart = hooks.onStart[0];
+        const onEnd = hooks.onEnd[0];
+
+        process.hrtime.bigint.mockImplementation(() => BigInt(1000000)); // 1ms in nanoseconds
+        onStart(); // call onStart to load in the start time
+        jest.clearAllMocks();
+
+        process.hrtime.bigint.mockImplementation(() => BigInt(4000000)); // 4ms in nanoseconds
 
+        await onEnd({
+          metafile: {
+            outputs: {
+              'file.js': {},
+            },
+          },
+        });
+
+        expect(fs.promises.writeFile).toHaveBeenCalledWith('[email protected]', '{"file.js":{},"durationMs":3}');
+      });
       it('should not log in watch mode', async () => {
         const plugin = timeBuild({ bundleName: 'mockBundleName', watch: true });
         const hooks = runSetupAndGetLifeHooks(plugin);

packages/one-app-dev-bundler/esbuild/plugins/time-build.js

@@ -31,8 +31,8 @@ const timeBuild = ({ bundleName, watch }) => ({
 
       if (!watch) { // watch has its own logging
         console.log(`${bundleName} bundle built in ${result.durationMs}ms`);
-
-        await fs.promises.writeFile(`.esbuild-stats.${bundleName}.json`, JSON.stringify({
+        const sanitizedName = bundleName.replace('/', '-');
+        await fs.promises.writeFile(`.esbuild-stats.${sanitizedName}.json`, JSON.stringify({
           ...result.metafile.outputs,
           durationMs: result.durationMs,
         }));