Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code path for Apple Pay validation with request retry #3892

Merged
merged 1 commit into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. Remove code path for Apple Pay validation with request retry

    With a recent change[1], we have enabled Apple Pay Merchant Validaton with
    `axios` and `hpagent`.
    
    The change has been successfully verified on the Test environment, where the
    code path with `axios` was switched on using an environment variable[2].
    
    Now that the code path with `axios` has been switched ON also on Production,
    then we are now able to stop using `requestretry` in pay-frontend by
    completely deleting the code path using it for the Apple Pay Merchant
    Validation.
    
    Note that whilst working on this code, we have also improved the Pay CLI, and
    that now it is possible to run Pay locally --with-egress-proxy. For this
    reason, we are also removing the code path using `axios` without a proxy URL,
    since it is not production like and it is not needed for local development
    either.
    
    Further information in JIRA[3].
    
    [1]
    #3891
    
    [2]
    alphagov/pay-infra#4913
    
    [3]
    https://payments-platform.atlassian.net/browse/PP-12853
    marcotranchino committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2312a43 View commit details
    Browse the repository at this point in the history