Remove code path for Apple Pay validation with request retry #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotranchino
changed the title
DomBelcher
previously requested changes
Aug 12, 2024
app/controllers/web-payments/apple-pay/merchant-validation.controller.js
Outdated
Show resolved
Hide resolved
app/controllers/web-payments/apple-pay/merchant-validation.controller.js
Outdated
Show resolved
Hide resolved
app/controllers/web-payments/apple-pay/merchant-validation.controller.js
Outdated
Show resolved
Hide resolved
With a recent change[1], we have enabled Apple Pay Merchant Validaton with `axios` and `hpagent`. The change has been successfully verified on the Test environment, where the code path with `axios` was switched on using an environment variable[2]. Now that the code path with `axios` has been switched ON also on Production, then we are now able to stop using `requestretry` in pay-frontend by completely deleting the code path using it for the Apple Pay Merchant Validation. Note that whilst working on this code, we have also improved the Pay CLI, and that now it is possible to run Pay locally --with-egress-proxy. For this reason, we are also removing the code path using `axios` without a proxy URL, since it is not production like and it is not needed for local development either. Further information in JIRA[3]. [1] #3891 [2] alphagov/pay-infra#4913 [3] https://payments-platform.atlassian.net/browse/PP-12853
marcotranchino
force-pushed
the
pp-12853-remove-requestretry-path
branch
from
79a8a55
to
2312a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a recent change[1], we have enabled Apple Pay Merchant Validaton with
axiosandhpagent.The change has been successfully verified on the Test environment, where the
code path with
axioswas switched on using an environment variable[2].Now that the code path with
axioshas been switched ON also on Production,then we are now able to stop using
requestretryin pay-frontend bycompletely deleting the code path using it for the Apple Pay Merchant
Validation.
Note that whilst working on this code, we have also improved the Pay CLI, and
that now it is possible to run Pay locally --with-egress-proxy. For this
reason, we are also removing the code path using
axioswithout a proxy URL,since it is not production like and it is not needed for local development
either.
Further information in JIRA[3].
[1]
#3891
[2]
https://github.com/alphagov/pay-infra/pull/4913
[3]
https://payments-platform.atlassian.net/browse/PP-12853