Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove deprecated set-output command #718

Merged
merged 2 commits into from
Jul 16, 2024
+13 −15
Merged

Fix: Remove deprecated set-output command #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dcbd29
Fix: Remove deprecated set-output command
damacus Jun 19, 2024
3439d45
Merge branch 'main' into fix-deprecated-output
damacus Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions action/diff/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ inputs:
required: false
python-version:
description: Python version used for running flux-local
default: '3.10'
default: "3.10"
strip-attrs:
description: Labels and annotations that should be stripped to reduce diff noise
default: helm.sh/chart,checksum/config,app.kubernetes.io/version,chart
Expand All @@ -39,13 +39,13 @@ inputs:
default: 10000
kustomize-build-flags:
description: Additional flags to pass to kustomize build
default: ''
default: ""
sources:
description: GitRepository or OCIRepository to include with optional source mappings like `flux-system` or `cluster=./kubernetes/`
default: ''
default: ""
token:
description: Token used for checkout action
default: '${{ github.token }}'
default: "${{ github.token }}"
required: false
outputs:
diff:
Expand All @@ -55,17 +55,16 @@ runs:
using: "composite"
steps:
- name: Verify Flux CLI
run:
flux --version || (echo "Could not find flux CLI, add https://fluxcd.io/flux/flux-gh-action/" && exit 1)
run: flux --version || (echo "Could not find flux CLI, add https://fluxcd.io/flux/flux-gh-action/" && exit 1)
shell: bash
- name: Copy requirements locally
id: copy-requirements
shell: bash
run: |
# `cache-dependency-path` seems to need to be within the current directory. Use a temporary directory
tempdir=$(mktemp --directory --tmpdir=. --suffix=-flux-local-diff-action)
cp ${{ github.action_path }}/../../requirements.txt $tempdir
echo "::set-output name=directory::${tempdir}"
cp ${{ github.action_path }}/../../requirements.txt ${tempdir}
echo "directory=${tempdir}" >> $GITHUB_OUTPUT
- name: Set up Python
uses: actions/setup-python@v5
with:
Expand Down
13 changes: 6 additions & 7 deletions action/test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,21 @@ inputs:
default: v1.9.0
python-version:
description: Python version used for running flux-local
default: '3.10'
default: "3.10"
debug:
description: When true, uses the DEBUG log level
default: false
kustomize-build-flags:
description: Additional flags to pass to kustomize build
default: ''
default: ""
sources:
description: GitRepository or OCIRepository to include with optional source mappings like `flux-system` or `cluster=./kubernetes/`
default: ''
default: ""
runs:
using: "composite"
steps:
- name: Verify Flux CLI
run:
flux --version || (echo "Could not find flux CLI, add https://fluxcd.io/flux/flux-gh-action/" && exit 1)
run: flux --version || (echo "Could not find flux CLI, add https://fluxcd.io/flux/flux-gh-action/" && exit 1)
shell: bash
- name: Copy requirements locally
id: copy-requirements
Expand All @@ -46,7 +45,7 @@ runs:
# `cache-dependency-path` seems to need to be within the current directory. Use a temporary directory
tempdir=$(mktemp --directory --tmpdir=. --suffix=-flux-local-diff-action)
cp ${{ github.action_path }}/../../requirements.txt $tempdir
echo "::set-output name=directory::${tempdir}"
echo "directory=${tempdir}" >> $GITHUB_OUTPUT
- name: Set up Python
uses: actions/setup-python@v4
with:
Expand All @@ -61,7 +60,7 @@ runs:
- uses: supplypike/setup-bin@v3
with:
uri: https://github.com/kyverno/kyverno/releases/download/${{ inputs.kyverno-version }}/kyverno-cli_${{ inputs.kyverno-version }}_linux_x86_64.tar.gz
name: 'kyverno-cli'
name: "kyverno-cli"
version: ${{ inputs.kyverno-version }}
if: ${{ inputs.enable-kyverno == 'true' }}
- name: Test cluster (flux-local)
Expand Down
Loading