Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove deprecated set-output command #718

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

damacus
Copy link
Contributor

@damacus damacus commented Jun 19, 2024

@allenporter
Copy link
Owner

Fixes #466

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (a4d8ae6) to head (3439d45).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          20       20           
  Lines        2165     2165           
=======================================
  Hits         2024     2024           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the CI is not running the Copy requirements locally step which was modified here, then it fails. Am I understanding the failure properly or is something else going on?

@damacus damacus force-pushed the fix-deprecated-output branch from 9e6a4d6 to 1dcbd29 Compare July 16, 2024 13:37
@damacus
Copy link
Contributor Author

damacus commented Jul 16, 2024

Yeah looks like I got the syntax wrong 🙄

Hopefully this'll work

@allenporter
Copy link
Owner

Thanks!

@allenporter allenporter merged commit 4f384c4 into allenporter:main Jul 16, 2024
25 checks passed
@damacus damacus deleted the fix-deprecated-output branch July 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants