Language bangla #108 #110
Open
Language bangla #108 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please update readme |
dorians
requested changes
Aug 23, 2023
src/test/groovy/pl/allegro/finance/tradukisto/ValueConvertersTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/internal/languages/bangle/BangleValuesTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/internal/languages/bangle/BangleValuesTest.groovy
Outdated
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/bangle/BangleValues.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/allegro/finance/tradukisto/internal/languages/bangle/BangleValues.java
Outdated
Show resolved
Hide resolved
|
I have changed the code, please check it now. |
dorians
previously approved these changes
Aug 28, 2023
jglaszka
reviewed
Aug 30, 2023
| @@ -45,7 +46,8 @@ public enum MoneyConverters { | |||
| SERBIAN_CYRILLIC_BANKING_MONEY_VALUE(serbianCyrillicContainer().getBankingMoneyConverter()), | |||
| FRENCH_BANKING_MONEY_VALUE(frenchContainer().getBankingMoneyConverter()), | |||
| BULGARIAN_BANKING_MONEY_VALUE(bulgarianContainer().getBankingMoneyConverter()), | |||
| DUTCH_BANKING_MONEY_VALUE(dutchContainer().getBankingMoneyConverter()); | |||
| DUTCH_BANKING_MONEY_VALUE(dutchContainer().getBankingMoneyConverter()), | |||
| BANGLA_BANKING_MONEY_VALUE(banglaContainer().getBankingMoneyConverter()); | |||
|
|
|||
There was a problem hiding this comment.
Please add your language also to the ValueConverters and LongConvertrs files
src/test/groovy/pl/allegro/finance/tradukisto/internal/languages/bangla/BanglaValuesTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/internal/languages/bangla/BanglaValuesTest.groovy
Show resolved
Hide resolved
src/test/groovy/pl/allegro/finance/tradukisto/internal/languages/bangla/BanglaValuesTest.groovy
Outdated
Show resolved
Hide resolved
|
@ronisarkarexe Hi, can you fix git conflicts, please? |
jglaszka
reviewed
Sep 6, 2023
| @Override | ||
| public Map<Integer, GenderForms> baseNumbers() { | ||
| return baseNumbersBuilder() | ||
| .put(1, "শূন্য") |
There was a problem hiding this comment.
Shouldn't it be 0?
.put(0, "শূন্য")
jglaszka
reviewed
Sep 6, 2023
|
|
||
| @Override | ||
| public GenderType genderType() { | ||
| return GenderType.NON_APPLICABLE; |
There was a problem hiding this comment.
needs to be imported:
import pl.allegro.finance.tradukisto.internal.languages.GenderType;
jglaszka
reviewed
Sep 6, 2023
|
|
||
| public String currency() { | ||
| return "৳"; | ||
| } |
There was a problem hiding this comment.
This class needs to have twoDigitsNumberSeparator method implemented
I will check, thank for mention |
|
I resolved conflicts in your PR |
jglaszka
reviewed
Oct 14, 2023
| @@ -320,4 +321,9 @@ public LongToStringConverter getLongConverter() { | |||
| public BigDecimalToStringConverter getBankingMoneyConverter() { | |||
| return bigDecimalConverter; | |||
| } | |||
|
|
|||
| public static Container banglaContainer() { | |||
| TurkishValues values = new BanglaValues(); | |||
There was a problem hiding this comment.
you need to change TurkishValues to BanglaValues, something like this:
BanglaValues values = new BanglaValues();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the Bangla (Bengali) language has been completed.
New language added. reference