-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hindi #108
Comments
@jglaszka Hey, I saw my language ( Bangla ) missing from the list, can I contribute to the change? |
sure, we are open for new languages :) |
Can you guide me to contribute? I am new to the open-source community. and I am so excited to work with you. |
Yes. What type of help do you need (language/git/business logic)? You can also check guide first: https://github.com/allegro/tradukisto/wiki/Create-your-first-Pull-Request. |
Question:-
|
|
@jglaszka thanks for the guidance. I created a pull request Please check it. |
@jglaszka Can you assign this issue to me, I will add Hindi Support. |
@jglaszka I have written all implementation for hindi language, only one catch left - "In Hindi, its two digits as separator after thousand and not like English where its always 3 digits between denomination change". Its like "xx,xx,xx,xxx.yy" format Trying to figure out that override functionality. Need to write new custom implementation of Number chunking. @ronisarkarexe Its same in bengali as well, I guess you missed that functionality. |
@girdharsourabh Today I will take a look at it. |
@girdharsourabh I reviewed your PR and added a few comments. |
@ronisarkarexe I checked your PR and I left questions to ensure if the code works properly: #110 (comment) |
Tradukisto is the library what converts numbers to human-readable words - for example from
14
tofourteen
. This issue was created to add support for counting in new language. Depending on how numeral system in your language is similar to other languages (english, arabic, german, slavic) and how many exceptions it have - it can be easy or more demanding.Implementing unit tests will be really helpful for you, I encourage you to create them first (TDD paradigm), before developing new changes in the code. You can run them in terminal with
./gradlew test
or green button in Intellij code editor.New language needs to have implementation for Container. Depending on how your language works, having conjugation, gender forms, custom chunking (typically divider is for 3 numbers) etc it may be needed to define more advanced container with custom implementations for counting, for example turkish. Tests will really be helpful for you to see if it needs custom implementations or not.
Also define
Values
- translations for base numers and for plural forms (thousands, millions etc).Feel free to ask if you have more questions, we will try to help you.
https://github.com/allegro/tradukisto/wiki/How-to-start-contributing
The text was updated successfully, but these errors were encountered: