Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_interop: Remove requirement for header values to be UTF-8 #672

Merged
merged 2 commits into from
Oct 23, 2023
Merged

http_interop: Remove requirement for header values to be UTF-8 #672

merged 2 commits into from
Oct 23, 2023

Commits on Oct 17, 2023

  1. http_interop: Test that non-UTF-8 sequences in header values are (wro… 

    …ngly) skipped during conversion
    @MarijnS95
    MarijnS95 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2cb7ff6 View commit details
    Browse the repository at this point in the history

  2. http_interop: Remove requirement for header values to be UTF-8 

    The current interop implementation forces fallibility around header
values when they are not UTF-8, both in conversions from `http` to
`ureq` as well as the other way around.

This should not be necessary as both `http` and `ureq` treat these as
opaque byte arrays internally, but unfortunately the current open API
for `ureq` and `http` make it a bit nasty to deal with.
    @MarijnS95
    MarijnS95 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a857d88 View commit details
    Browse the repository at this point in the history