http_interop: Remove requirement for header values to be UTF-8 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
from
11189ad
to
b46a442
Compare
6 tasks
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
from
b46a442
to
1d1d3a8
Compare
|
Can we construct a test for this? |
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
from
1d1d3a8
to
485656a
Compare
|
Sure! I added them for requests but probably also have to add them for responses... And found that the current |
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
3 times, most recently
from
bcb160a
to
c354e58
Compare
|
Looks great! Thanks! Maybe that test helper function need to be allowed unused for some test feature flag combo? |
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
from
c354e58
to
9171db5
Compare
|
Yeah. It's a bit nasty though as it's a useful function, just not something to expose publicly and the conditional is quite large now... |
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
from
9171db5
to
458d80e
Compare
…ngly) skipped during conversion
The current interop implementation forces fallibility around header values when they are not UTF-8, both in conversions from `http` to `ureq` as well as the other way around. This should not be necessary as both `http` and `ureq` treat these as opaque byte arrays internally, but unfortunately the current open API for `ureq` and `http` make it a bit nasty to deal with.
MarijnS95
force-pushed
the
http-interop-remove-utf8-header-value-requirement
branch
from
458d80e
to
a857d88
Compare
algesten
approved these changes
Oct 23, 2023
|
Thank you! This looks great! |
MarijnS95
deleted the
http-interop-remove-utf8-header-value-requirement
branch
|
@algesten thanks! This should be the last of my PRs to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @kade-robertson
The current interop implementation forces fallibility around header values when they are not UTF-8, both in conversions from
httptoureqas well as the other way around.This should not be necessary as both
httpandureqtreat these as opaque byte arrays internally, but unfortunately the current open API forureqandhttpmake it a bit nasty to deal with.