Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-components): ensure the passkey prompt always shows up when qp is present #978

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Sep 23, 2024

Pull Request Checklist


PR-Codex overview

This PR updates the versioning across multiple files and introduces new functionality in the PasskeyAdded component and context.tsx. It also enhances the auth flow by clearing URL parameters and adjusting the authentication state handling.

Detailed summary

  • Updated VERSION from "4.0.0-beta.5" to "4.0.0-beta.6" in multiple files.
  • Added useAuthContext import in passkey-added.tsx.
  • Implemented a timeout to set the auth step to "complete" in PasskeyAdded.
  • Introduced clearAuthParams function to delete specific URL parameters.
  • Refactored resetAuthStep to use clearAuthParams.
  • Updated the dependencies in the useEffect for auth step handling.
  • Added a new useEffect to clear auth parameters when the auth step is "complete".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 4:37pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 4:37pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants