Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passkey flow in demo app #969

Merged
merged 9 commits into from
Sep 25, 2024
Merged

feat: allow passkey flow in demo app #969

merged 9 commits into from
Sep 25, 2024

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Sep 17, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the UI components and optimizing the configuration handling in the application. It includes updates to CSS classes, the addition of a new component, and improvements in the usage of hooks.

Detailed summary

  • Updated dependency array in useEffect in state.tsx to include updateConfig.
  • Added MintDemoWrapper component in MintDemoWrapper.tsx.
  • Modified modal class in modal.tsx to include overflow-hidden.
  • Added z-10 class to a sticky header in page.tsx.
  • Reformatted imports in AuthCardWrapper.tsx.
  • Made layout adjustments in AuthCardWrapper for better structure and readability.
  • Enhanced logout button functionality in AuthCardWrapper.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Testing steps

Before this PR it was impossible to get to the passkey screen as once you accepted the email invitation you would be only presented with a logout button.

  • In the demo app enter your email

  • Accept the email invitation

  • You should be presented with the passkey modal
    Screenshot 2024-09-25 at 9 25 40 AM

  • enable or skip the passkey and you will be presented with the logout button.
    Screenshot 2024-09-20 at 9 57 13 AM

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 2:50pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 2:50pm

rthomare
rthomare previously approved these changes Sep 18, 2024
@rthomare rthomare self-requested a review September 18, 2024 17:19
@rthomare
Copy link
Collaborator

Sorry for the accidental accept!

@RobChangCA RobChangCA changed the title feat: allow passkey flow in demo app. handleAuthSuccess callback whe… feat: allow passkey flow in demo app. Sep 20, 2024
@RobChangCA RobChangCA marked this pull request as ready for review September 20, 2024 13:57
@moldy530
Copy link
Collaborator

I've merged in the fix for react that handles the QP much better and makes sure the pop-up is always shown. is there anything left in this PR that needs to be included?

Copy link
Collaborator

@rthomare rthomare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue other than that looks good!

account-kit/react/src/components/auth/context.ts Outdated Show resolved Hide resolved
@RobChangCA RobChangCA merged commit bacf9bd into main Sep 25, 2024
6 checks passed
@RobChangCA RobChangCA deleted the lazer-passkey branch September 25, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants