-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow passkey flow in demo app #969
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry for the accidental accept! |
d546538
to
8133c77
Compare
071abc7
to
666a2a3
Compare
098af23
to
b0eb24f
Compare
5c552a7
to
c70b60c
Compare
I've merged in the fix for |
Co-authored-by: Michael Moldoveanu <[email protected]>
e46aeeb
to
ef070f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small issue other than that looks good!
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the UI components and optimizing the configuration handling in the application. It includes updates to CSS classes, the addition of a new component, and improvements in the usage of hooks.
Detailed summary
useEffect
instate.tsx
to includeupdateConfig
.MintDemoWrapper
component inMintDemoWrapper.tsx
.modal.tsx
to includeoverflow-hidden
.z-10
class to a sticky header inpage.tsx
.AuthCardWrapper.tsx
.AuthCardWrapper
for better structure and readability.AuthCardWrapper.tsx
.Testing steps
Before this PR it was impossible to get to the passkey screen as once you accepted the email invitation you would be only presented with a logout button.
In the demo app enter your email
Accept the email invitation
You should be presented with the passkey modal
enable or skip the passkey and you will be presented with the logout button.