Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): always pass credentials to kargo render #1696

Merged
merged 1 commit into from
Mar 27, 2024

always pass credentials to kargo render

3238fe0
Select commit
Loading
Failed to load commit list.
Merged

fix(controller): always pass credentials to kargo render #1696

always pass credentials to kargo render
3238fe0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 27, 2024 in 1s

43.92% (-0.02%) compared to f96a413

View this Pull Request on Codecov

43.92% (-0.02%) compared to f96a413

Details

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 43.92%. Comparing base (f96a413) to head (3238fe0).

Files Patch % Lines
internal/kargo-render/render.go 0.00% 6 Missing ⚠️
internal/controller/promotion/git.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
- Coverage   43.93%   43.92%   -0.02%     
==========================================
  Files         203      203              
  Lines       13061    13070       +9     
==========================================
+ Hits         5739     5741       +2     
- Misses       7075     7082       +7     
  Partials      247      247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov