Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastfile: Run tests with BUILD_LIBRARY_FOR_DISTRIBUTION. #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

byohay
Copy link

@byohay byohay commented Jan 10, 2022

Solves #266

@byohay byohay force-pushed the feature/support-build-library-for-distribution branch from a4ea8db to 082830c Compare January 10, 2022 17:11
@ghost
Copy link

ghost commented Jan 11, 2022

Is the intent here just to make sure that running tests with BUILD_LIBRARY_FOR_DISTRIBUTION doesn't break anything? I would have expected some kind of change in the project file or package spec as well.

@byohay
Copy link
Author

byohay commented Jan 13, 2022

To my understanding, if your clients don't intend to build JOSESwift separately you shouldn't enable library evolution (See here, under "When to enable library evolution support"). So if your clients wants to build it separately they should enable it themselves.
On another matter: Clients who pre-compile the library will use the archive command, but the current check runs the tests. Should I add another step that checks with the archive command? Or is it an overkill to add a step just for that?

@byohay
Copy link
Author

byohay commented Mar 21, 2022

@nathan-mohemian what are your thoughts on the matter?

@haeser haeser force-pushed the feature/support-build-library-for-distribution branch from 082830c to ebb6b75 Compare August 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant