Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for library evolution #266

Open
byohay opened this issue Jan 3, 2022 · 3 comments
Open

Support for library evolution #266

byohay opened this issue Jan 3, 2022 · 3 comments

Comments

@byohay
Copy link

byohay commented Jan 3, 2022

Hi,
We've been using JOSESwift for some time, and we want to start precompiling to save build time. I know that this repository doesn't provide binaries, but it would still be helpful for us if this project would be guaranteed to compile with BUILD_LIBRARY_FOR_DISTRIBUTION enabled. Otherwise we might have to diverge from your fork to make it compile.
In practice this probably means creating tests that compile with this flag and check that the build succeeds.
The same was done in GRDB.

@ghost
Copy link

ghost commented Jan 3, 2022

@byohay thanks for bringing this up, at the moment there aren't plans to implement this. (For future readers, see #237 (comment) also.)

That being said, we'd welcome a PR if you have to to dig into this for your internal use anyway.

@byohay
Copy link
Author

byohay commented Jan 10, 2022

@nathan-mohemian thanks! I opened a PR #267

@ghost
Copy link

ghost commented Jan 10, 2022

Glad to hear it! Will take a look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant