-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer creation of SimpleCookie objects in the web server until needed #9895
base: master
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #9895 will improve performances by 17.52%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9895 +/- ##
==========================================
+ Coverage 98.70% 98.72% +0.02%
==========================================
Files 121 121
Lines 36621 36629 +8
Branches 4376 4378 +2
==========================================
+ Hits 36146 36163 +17
+ Misses 319 314 -5
+ Partials 156 152 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Todo
|
related issue #2779 We create these objects even if there are no cookies
6b63eba
to
7076bc1
Compare
if old is not None and old.coded_value == "": | ||
# deleted cookie | ||
self._cookies.pop(name, None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unreachable since cookies are always set with a path
related issue #2779
We create these objects even if there are no cookies. There are some small performance improvements and some memory savings on each request.