Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9940/9ca1a581 backport][3.11] Add benchmarks for creating web responses #9942

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 17, 2024

This is a backport of PR #9940 as merged into master (9ca1a58).

Focused benchmark to measure changes in web.*Response creation time for #9895

@bdraco bdraco enabled auto-merge (squash) November 17, 2024 18:56
Copy link

codspeed-hq bot commented Nov 17, 2024

CodSpeed Performance Report

Merging #9942 will not alter performance

Comparing patchback/backports/3.11/9ca1a58114fd2021e382ccdc96085aa095948009/pr-9940 (1cdeac0) with 3.11 (9c81667)

Summary

✅ 37 untouched benchmarks

🆕 5 new benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/9ca1a58114fd2021e382ccdc96085aa095948009/pr-9940 Change
🆕 test_simple_web_response N/A 634 µs N/A
🆕 test_simple_web_stream_response N/A 391.1 µs N/A
🆕 test_web_response_with_bytes_body N/A 732.7 µs N/A
🆕 test_web_response_with_headers N/A 1.2 ms N/A
🆕 test_web_response_with_text_body N/A 857.8 µs N/A

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (9c81667) to head (1cdeac0).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9942   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         121      122    +1     
  Lines       36677    36710   +33     
  Branches     4414     4424   +10     
=======================================
+ Hits        35948    35981   +33     
  Misses        545      545           
  Partials      184      184           
Flag Coverage Δ
CI-GHA 97.90% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.60% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.49% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.71% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.57% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.11% <100.00%> (-0.05%) ⬇️
Py-3.11.10 97.18% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.64% <100.00%> (+0.01%) ⬆️
Py-3.12.7 97.68% <100.00%> (+0.01%) ⬆️
Py-3.13.0 97.67% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.50% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.07% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.64% <100.00%> (-0.01%) ⬇️
VM-macos 96.71% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.60% <100.00%> (+<0.01%) ⬆️
VM-windows 94.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 6cf4497 into 3.11 Nov 17, 2024
32 of 33 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/9ca1a58114fd2021e382ccdc96085aa095948009/pr-9940 branch November 17, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant