bump moto

[thehesiod]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (4a096bd) to head (1e0264d).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
tests/conftest.py	92.00%	2 Missing ⚠️
tests/mock_server.py	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
+ Coverage   87.90%   88.66%   +0.75%     
==========================================
  Files          68       67       -1     
  Lines        5987     5875     -112     
==========================================
- Hits         5263     5209      -54     
+ Misses        724      666      -58     

Flag	Coverage Δ
unittests	88.66% <94.64%> (+0.75%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thehesiod]

ok finally ready

[thehesiod]

btw updated the merge to be squash and merge to avoid master pollution

[jakob-keller]

Awesome, this one is much overdue!

I have a few minor questions and suggestions, but this should be easy to follow up on.

Thanks for the effort!

[thehesiod]

thanks for the review! lemme c what I can do about this coverage

[jakob-keller]

thanks for the review! lemme c what I can do about this coverage

The merge is blocked due to missing verified commit signatures.

[thehesiod]

will fix

[thehesiod]

@jakob-keller crap it's the pre-commit thing, how do we fix that thing so it's signed?

[thehesiod]

https://github.com/mattlqx/pre-commit-sign?

[jakob-keller]

@jakob-keller crap it's the pre-commit thing, how do we fix that thing so it's signed?

I guess the easiest way would be for you to squash the unverified commit and force push your branch.

[jakob-keller]

https://github.com/mattlqx/pre-commit-sign?

The unverified commit originates from https://pre-commit.ci. I don't see a way to make that spit out verified commits. Going forward, I guess we need to either drop pre-commit.ci or drop the verification requirement. I'd be in favor of the former.

[thehesiod]

@jakob-keller ya I say drop the pre-commit from being able to modify the PR. Failing is fine, then having the user fix it is better otherwise author may not notice something changing their code on their behalf potentially leading to bugs...like especially since we want to mostly keep formatting from botocore