Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit.ci should not autofix PRs #1298

Closed
jakob-keller opened this issue Feb 17, 2025 · 0 comments · Fixed by #1299
Closed

pre-commit.ci should not autofix PRs #1298

jakob-keller opened this issue Feb 17, 2025 · 0 comments · Fixed by #1299
Assignees
@jakob-keller
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@jakob-keller
Copy link
Collaborator 

          @jakob-keller ya I say drop the pre-commit from being able to modify the PR.  Failing is fine, then having the user fix it is better otherwise author may not notice something changing their code on their behalf potentially leading to bugs...like especially since we want to mostly keep formatting from botocore

Originally posted by @thehesiod in #1297 (comment)
@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Feb 17, 2025
@jakob-keller jakob-keller mentioned this issue Feb 17, 2025
Merged
13 tasks
@jakob-keller jakob-keller self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakob-keller jakob-keller

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable autofix PRs by pre-commit.ci jakob-keller/aiobotocore
1 participant
@jakob-keller