Pin stride version in all the places we specify pip install #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
NewtonSander
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Pin stride version in all the places we specify pip install * Fix dead link
NewtonSander
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Pin stride version in all the places we specify pip install * Fix dead link
NewtonSander
added a commit
that referenced
this pull request
Oct 16, 2023
* Adding CT loading functionality to web * Fixing issues with ct loading * Adding support to load zipped dicom CTs * Spellcheck * Adding absorption to shaped grid * Exposing CT scan info to the FE, so that we can make FE validations * Constraining the distance from origin based on the CT size * Removing unused pynrrd lib * Small refactoring * Refactoring * Using voxels spacing when creating the grid * Adding dependency * Reverting the X/Y swap * Removing gunicorn and replacing the make tarket web with web-development * Pin stride version in all the places we specify pip install (#163) * Pin stride version in all the places we specify pip install * Fix dead link * Poetry version updated * Add focal pressure, focal volume, and FWHM to results metrics (#152) * Poetry version updated --------- Co-authored-by: newton sander <[email protected]> Co-authored-by: charles <[email protected]> Co-authored-by: d-lucena <[email protected]>
NewtonSander
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Pin stride version in all the places we specify pip install * Fix dead link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#142
Introduction
NDK uses the
stridesimulation software, and we instruct users topip installfrom Github, picking up the latest development version.stridecurrently has a bug or 2 causing some NDK tests to fail (and potentially breaking for any new NDK users).Changes
strideto a known-good commit SHA. Categorized as "known-good" simply as having passed the automated tests: Add focal pressure, focal volume, and FWHM to results metrics #152In the future:
poetryso it is one less thing to track.strideto do releases for this to work.Behavior
pip install stridecommands should have respective commit hashesFYI @conditg